Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter_by_aoi for ObjectDetectionLabels #746

Merged
merged 1 commit into from Apr 3, 2019
Merged

Fix filter_by_aoi for ObjectDetectionLabels #746

merged 1 commit into from Apr 3, 2019

Conversation

lewfish
Copy link
Contributor

@lewfish lewfish commented Apr 3, 2019 •
edited

Overview

This PR fixes a bug, enabling using AOIs with object detection tasks, and adds two unit tests for this functionality.

Testing

  • Modified the Vegas buildings object detection to use a single scene with an AOI overlapping it (and then again with an AOI that does not overlap). This motivates me to do Add AOIs to integration tests #675 even more.

Closes #740

@lewfish lewfish added needs-backport This PR needs to be backported to release branches review labels Apr 3, 2019
@lewfish lewfish merged commit 82af978 into master Apr 3, 2019
@lewfish lewfish removed the review label Apr 3, 2019
@lewfish lewfish deleted the lf/fix-aoi branch April 3, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-backport This PR needs to be backported to release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluation for object detection with AOIs crashes
1 participant
@lewfish