Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter_by_aoi for ObjectDetectionLabels #746

Merged
merged 1 commit into from Apr 3, 2019
Merged

Fix filter_by_aoi for ObjectDetectionLabels #746

merged 1 commit into from Apr 3, 2019

Conversation

@lewfish
Copy link
Contributor

@lewfish lewfish commented Apr 3, 2019

Overview

This PR fixes a bug, enabling using AOIs with object detection tasks, and adds two unit tests for this functionality.

Testing

  • Modified the Vegas buildings object detection to use a single scene with an AOI overlapping it (and then again with an AOI that does not overlap). This motivates me to do #675 even more.

Closes #740

@lewfish lewfish force-pushed the lf/fix-aoi branch from dbe3909 to a791585 Apr 3, 2019
@lewfish lewfish merged commit 82af978 into master Apr 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lewfish lewfish removed the review label Apr 3, 2019
@lewfish lewfish deleted the lf/fix-aoi branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant