Remove security, subnet, and parameter groups #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of defining ingress/egress rules on the aws_security_group resource, emit the security group ID so that the module consumer can specifiy their own rules.
Since modules do not support attributes as maps, two new top level module attributes have been added for `project` and `environment`. These variables are used to add tags to all AWS resources that support them.
|
+1. Tested via azavea/pwd-stormdrain-marking#41. |
hectcastro
force-pushed
the
feature/hmc/aws-security-group-rule
branch
2 times, most recently
from
6f91958
to
bee0c85
Compare
hectcastro
changed the title
Instead of defining RDS subnet groups and parameter groups, emit the necessary IDs so that the module consumer can specify their own customized resources.
hectcastro
force-pushed
the
feature/hmc/aws-security-group-rule
branch
from
bee0c85
to
a288187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of defining security, RDS subnet, and parameter groups, emit the necessary IDs so that the module consumer can specify their own customized resources.
Also, add two top level module attributes
projectandenvironment. These variables are used to add tags to all AWS resources that support them.Testing
The easiest way to test this is probably to test https://github.com/azavea/pwd-stormdrain-marking/pull/41.