Remove the ConcurrentOrderedMap. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reasons for removing it are: - It loses the performance characteristics of ConcurrentHashMap as it has an internal Vector which limits it's concurrency. - #putIfAbsent(K, V) isn't thread safe. It calls containsKey and then put, but doesn't do it atomically so it's not deterministic. - #remove(key, value) isn't thread safe. It removes the entry from the ConcurrentHashMap and then removes it from the internal Vector without any locking (another thread could be adding in between this).
azeckoski
added a commit
that referenced
this pull request
Mar 29, 2015
Remove the ConcurrentOrderedMap.
|
This was taken directly from a set of spring utilities so I have no problem dropping it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons for removing it are:
has an internal Vector which limits it's concurrency.
put, but doesn't do it atomically so it's not deterministic.
ConcurrentHashMap and then removes it from the internal Vector without
any locking (another thread could be adding in between this).