Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ConcurrentOrderedMap. #6

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Remove the ConcurrentOrderedMap. #6

merged 1 commit into from
Mar 29, 2015

Commits on Mar 29, 2015

  1. Remove the ConcurrentOrderedMap. 

    The reasons for removing it are:
- It loses the performance characteristics of ConcurrentHashMap as it
has an internal Vector which limits it's concurrency.
- #putIfAbsent(K, V) isn't thread safe. It calls containsKey and then
put, but doesn't do it atomically so it's not deterministic.
- #remove(key, value) isn't thread safe. It removes the entry from the
ConcurrentHashMap and then removes it from the internal Vector without
any locking (another thread could be adding in between this).
    @buckett
    buckett committed Mar 29, 2015
    Configuration menu
    Copy the full SHA
    21c67f7 View commit details
    Browse the repository at this point in the history