refactor: module single-value-selector

azerothcore · Jul 15, 2019 · 5023ad4 · 5023ad4
1 parent 649c9d8
commit 5023ad4
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 23 deletions.
diff --git a/src/app/app.module.ts b/src/app/app.module.ts
@@ -51,31 +51,20 @@ import { SpawnsComponent } from './components/editors/creature/spawns/spawns.com
 import { SpawnsAddonComponent } from './components/editors/creature/spawns-addon/spawns-addon.component';
 import { QueryErrorComponent } from './components/editors/shared/query-output/query-error/query-error.component';
 import { uiSwitchConfig } from './config/ui-switch.config';
-import {
-  SingleValueSelectorBtnComponent
-} from './components/editors/shared/selectors/single-value-selector/single-value-selector-btn.component';
-import {
-  SingleValueSelectorModalComponent
-} from './components/editors/shared/selectors/single-value-selector/single-value-selector-modal.component';
 import { ComingSoonComponent } from './components/editors/coming-soon/coming-soon.component';
 
 const DEFAULT_PERFECT_SCROLLBAR_CONFIG: PerfectScrollbarConfigInterface = {
   suppressScrollX: true
 };
 
 @NgModule({
-  entryComponents: [
-    SingleValueSelectorModalComponent,
-  ],
   declarations: [
     AppComponent,
     DashboardComponent,
     WebviewDirective,
     SidebarComponent,
     MainWindowComponent,
     QueryErrorComponent,
-    SingleValueSelectorModalComponent,
-    SingleValueSelectorBtnComponent,
     HighlightjsWrapperComponent,
     CreateComponent,
     TopBarComponent,

diff --git a/...ditors/shared/selectors/single-value-selector/single-value-selector-btn.component.spec.ts b/...ditors/shared/selectors/single-value-selector/single-value-selector-btn.component.spec.ts
@@ -1,18 +1,15 @@
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { ModalModule } from 'ngx-bootstrap';
 
 import { SingleValueSelectorBtnComponent } from './single-value-selector-btn.component';
+import { SingleValueSelectorModule } from './single-value-selector.module';
 
 describe('SingleValueSelectorBtnComponent', () => {
   let component: SingleValueSelectorBtnComponent;
   let fixture: ComponentFixture<SingleValueSelectorBtnComponent>;
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
-      declarations: [ SingleValueSelectorBtnComponent ],
-      imports: [
-        ModalModule.forRoot(),
-      ]
+      imports: [ SingleValueSelectorModule ],
     })
     .compileComponents();
   }));

diff --git a/...tors/shared/selectors/single-value-selector/single-value-selector-modal.component.spec.ts b/...tors/shared/selectors/single-value-selector/single-value-selector-modal.component.spec.ts
@@ -1,9 +1,8 @@
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { NgxDatatableModule } from '@swimlane/ngx-datatable';
 import { BsModalRef } from 'ngx-bootstrap';
 
 import { SingleValueSelectorModalComponent } from './single-value-selector-modal.component';
-import { CommonTestModule } from '../../../../../test-utils/common-test.module';
+import { SingleValueSelectorModule } from './single-value-selector.module';
 
 describe('SingleValueSelectorModalComponent', () => {
   let component: SingleValueSelectorModalComponent;
@@ -13,11 +12,7 @@ describe('SingleValueSelectorModalComponent', () => {
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
-      declarations: [ SingleValueSelectorModalComponent ],
-      imports: [
-        CommonTestModule,
-        NgxDatatableModule,
-      ],
+      imports: [ SingleValueSelectorModule ],
       providers: [
         BsModalRef,
       ],

diff --git a/...components/editors/shared/selectors/single-value-selector/single-value-selector.module.ts b/...components/editors/shared/selectors/single-value-selector/single-value-selector.module.ts
@@ -0,0 +1,26 @@
+import { NgModule } from '@angular/core';
+import { BrowserModule } from '@angular/platform-browser';
+import { ModalModule } from 'ngx-bootstrap';
+import { NgxDatatableModule } from '@swimlane/ngx-datatable';
+
+import { SingleValueSelectorModalComponent } from './single-value-selector-modal.component';
+import { SingleValueSelectorBtnComponent } from './single-value-selector-btn.component';
+
+@NgModule({
+  entryComponents: [
+    SingleValueSelectorModalComponent,
+  ],
+  declarations: [
+    SingleValueSelectorModalComponent,
+    SingleValueSelectorBtnComponent,
+  ],
+  imports: [
+    BrowserModule,
+    ModalModule.forRoot(),
+    NgxDatatableModule,
+  ],
+  exports: [
+    SingleValueSelectorBtnComponent,
+  ],
+})
+export class SingleValueSelectorModule {}