Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldserver don't return an error when data is missing with GitBash #13552

Open
ghost opened this issue Oct 26, 2022 · 5 comments
Open

Worldserver don't return an error when data is missing with GitBash #13552

ghost opened this issue Oct 26, 2022 · 5 comments
Labels
Bash Confirmed CORE Related to the core

Comments

@ghost
Copy link

ghost commented Oct 26, 2022

Current Behaviour

If you don't have data files or don't set the data path, worldserver don't return an error.

Expected Blizzlike Behaviour

Should return an error

Source

No response

Steps to reproduce the problem

  1. Launch git bash shell from your server folder
  2. Remove data files or data path in .conf
  3. write and launch in the shell: ./worldserver.exe
  4. Look if worldserver return an error

Extra Notes

No response

AC rev. hash/commit

47bf00a

Operating system

Windows 11

Custom changes or Modules

No response

@ghost ghost added Confirmed CORE Related to the core Bash labels Oct 26, 2022
@ghost ghost changed the title Worldserver don't return an error when data directory is missing Worldserver don't return an error when data is missing Oct 26, 2022
@heyitsbench
Copy link
Contributor

Is

Map file 'path\bin\RelWithDebInfo\Data/maps/0004331.map': does not exist!

not considered an error?

@ghost
Copy link
Author

ghost commented Oct 27, 2022

Is

Map file 'path\bin\RelWithDebInfo\Data/maps/0004331.map': does not exist!

not considered an error?

wich OS do you use ? Is it Git bash ? If yes, wich version ?

@heyitsbench
Copy link
Contributor

Just Windows 10, no Git bash. I apologize, I didn't realize this was specific to that.

@Kitzunu
Copy link
Member

Kitzunu commented Oct 27, 2022

You should specify your issue to git bash.

@Kitzunu Kitzunu changed the title Worldserver don't return an error when data is missing Worldserver don't return an error when data is missing with GitBash Oct 30, 2022
@xxy-mm
Copy link

xxy-mm commented Dec 13, 2023

The error also occurs when using the terminal on win11. I think we should tell the developers to setup the datadir in the worldserver.conf.
DataDir = "./Data"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Confirmed CORE Related to the core
Projects
None yet
Development

No branches or pull requests

3 participants