Docker Compose mysql password requires quoting

[lthurlow]

Current Behaviour

If a mysql password contains a characters that can be interrupted the shell is happy to do so. !;& , etc.

This will cause docker compose up to fail with ac-database being unhealthy because the test command fails by expanding the password.

Expected Blizzlike Behaviour

The password that gets loaded into docker compose needs to be quoted to prevent the shell from interpreting.

Source

https://github.com/azerothcore/azerothcore-wotlk/blob/master/docker-compose.yml#L25

Steps to reproduce the problem

1. Set MYSQL_ROOT_PASSWORD with a password that can be interpreted by shell: My password is &secure ! Hope?;
2. Build containers (docker compose build)
3. Run containers (docker compose --env-file .envs up -d where .envs contains the environment variable or MYSQL_ROOT_PASSWORD="My password is &secure ! Hope?;" docker compose up -d)
4. Run fails after timeout because test command continues to exit with non-zero due to password being interpreted.

Extra Notes

test: "/usr/bin/mysql --user=root --password=\"$${MYSQL_ROOT_PASSWORD}\" --execute \"SHOW DATABASES;\""

AC rev. hash/commit

c8abb8c

Operating system

Debian 11

Custom changes or Modules

N/A