Fix issue with leaving queue #5
Conversation
- Fix issue with leaving queue
src/npc_arena1v1.cpp
Outdated
| @@ -279,8 +279,12 @@ class npc_1v1arena : public CreatureScript | |||
|
|
|||
| case 3: // Leave Queue | |||
| { | |||
| uint8 arenaType = ARENA_TYPE_5v5; | |||
| if (player->InBattlegroundQueueForBattlegroundQueueType(BATTLEGROUND_QUEUE_5v5)) | |||
| arenaType = ARENA_TYPE_5v5; | |||
There was a problem hiding this comment.
why this reassignment to the same value?
There was a problem hiding this comment.
This PR contain code duplicate of #4
I think we could close it and focus on #4 that contains more improvements, do you agree?
@poszer, @Winfidonarleyan?
Are you serious? :D
|
This PR contain code duplicate of #4
I think we could close this and focus on #4 that contains more improvements, do you agree? |
|
And to be clear, this commit is created before other one, tested and confirmed as working one |
|
tested and working. I can correctly leave the Arena Queue clicking on NPC gossip |
|
We could merge both PRs to give the credits to both. |
|
agree, please merge both |
|
Thank you @poszer can merge this |
|
for some reasons squash failed, it merged without squashing commits |
The other PR is not needed. The module works now perfectly except Skirmish. And other PR commit wont fix it |
|
@Poszer please discuss it in the other pr, not here. I don't have time to check it now |
Closes: #2
#3 (comment)