Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Missing items on AH under several categories #74

Open
ChrisFredriksson opened this issue Sep 12, 2023 · 3 comments
Open

Bug: Missing items on AH under several categories #74

ChrisFredriksson opened this issue Sep 12, 2023 · 3 comments

Comments

@ChrisFredriksson
Copy link

ChrisFredriksson commented Sep 12, 2023

Current Behaviour

Missing items under

  • Consumable -> Item Enhancement

Scroll of Enchant Boots - Lesser Spirit (item ID# 38819)
and all other enchantment scrolls.

  • Trade Goods - Armor Enchantment

Armor Vellum (item ID# 38682/37602/43145)

  • Trade Goods - Weapon Enchantment

Weapon Vellum (item ID# 39349/39350/43146)

None of these are listed in the DB table "mod_auctionhousebot_disabled_items".

Expected Behaviour

These items should be possible to find on the AH.

Steps to reproduce the problem

Launch server with AHBot module

Extra Notes

I have set minitems to 140 000 and maxitems to 150 000.

None of these are listed in the DB table "mod_auctionhousebot_disabled_items".

AC rev. hash/commit

AzerothCore rev. 1209d61565cb+ 2023-08-11 22:20:06 +0000 (master branch)

Operating system

Debian 12 x64

Custom changes or Modules

AutoBalance
IndividualProgression
SoloLFG
NPCBots

@Akaitatsu
Copy link

Akaitatsu commented Nov 14, 2023

I am having a similar issue and got to digging. Based on the query I see in AuctionHouseBot.cpp (see below), it's only pulling items that show up in loot tables. Sure enough, the item IDs mentioned by @ChrisFredriksson are not in the results. I was looking for more projectiles in AH, but there are very few in the loot tables.

SELECT item FROM creature_loot_template UNION
SELECT item FROM reference_loot_template UNION
SELECT item FROM disenchant_loot_template UNION
SELECT item FROM fishing_loot_template UNION
SELECT item FROM gameobject_loot_template UNION
SELECT item FROM item_loot_template UNION
SELECT item FROM milling_loot_template UNION
SELECT item FROM pickpocketing_loot_template UNION
SELECT item FROM prospecting_loot_template UNION
SELECT item FROM skinning_loot_template

If I add npc_vendor and spell_loot_template I get more of the items but still not everything. For example, the spell_loot_template table includes Armor/Weapon Vellum and Armor/Weapon Vellum III, but not II.

I am still digging into the database, but I can't seem to find anything else that would identify items that are crafted by players.

Edit: I noticed after posting this that npc_vendor is already captured as part of the logic for vendor items and trade goods.

@Akaitatsu
Copy link

@ChrisFredriksson, #73 is getting some attention and this issue appears to have the same cause. I think you could close this one as a duplicate so it doesn't cause any confusion.

@spacefox-platforms
Copy link

a large number of herbs (basically anything past most classic herbs, but even then, there's a good number that are missing) never appear. heavy leather is never present either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants