Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(DB/SAI): Use new cmake macros; update texts & model; take over preferences, templates etc. from skeleton-module #17

Merged
5 commits merged into from Jan 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2019

  • Use new cmake macros
  • Update texts in order to give the player a clue what this NPC is all about
  • Update the model to the Northrend White Worgen
  • take over preferences, templates, scripts etc. from the skeleton module
  • Allow config reloading in order to dynamically change the pet lists

Tested build and in-game under Ubuntu 16.04

@ghost
Copy link
Author

ghost commented Jan 26, 2019

@dunjeon
Could you please test this PR on occasion?

@dunjeon
Copy link

dunjeon commented Jan 26, 2019

@Stoabrogga Sure thing!

@ghost
Copy link
Author

ghost commented Jan 26, 2019

@dunjeon
Great, thanks. Don't forget to apply the SQL script.

@dunjeon
Copy link

dunjeon commented Jan 26, 2019

@Stoabrogga I'll be able to do this tomorrow. =)

@ghost
Copy link
Author

ghost commented Jan 27, 2019

@dunjeon
No hurry, thanks 👍

@dunjeon
Copy link

dunjeon commented Jan 27, 2019

@Stoabrogga
Merged, compiled, SQL applied without error. I have tested the module and it is currently running live on my test server. Nice Job! Thanks for your effort =)

@ghost ghost merged commit dc9da64 into azerothcore:master Jan 27, 2019
@ghost
Copy link
Author

ghost commented Jan 27, 2019

Merged. Thanks for testing and your feedback @dunjeon

@ghost ghost deleted the cmake branch January 27, 2019 20:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant