Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized "data/" directory structure #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dot-snack
Copy link

@dot-snack dot-snack commented May 2, 2024

Changes Proposed:

  • Modernize Directory structure to enable automatic import of SQL with autoupdate
  • Remove obsolete files
  • Add current module template files

Issues Addressed:

  • Current module requires manual import of SQL
  • Module format is outdated

SOURCE:

  • Current Readme outlines obsolete method or manual import

Tests Performed:

  • Tested on a fresh compile of azerothcore/azerothcore-wotlk
  • Tested all transmog functions in-game and verified databases had correct imports

How to Test the Changes:

  1. Place in modules folder
  2. Compile as normal
  3. Spawn npc and test functions

…clude.sh code, added "apps/ci" and pr template
@dot-snack dot-snack changed the title Modernized "data/" directory structure, removed obsolete .conf and in… Modernized "data/" directory structure May 2, 2024
@Helias Helias requested a review from Nyeriah May 3, 2024 15:03
@Nyeriah
Copy link
Member

Nyeriah commented Jun 10, 2024

I wouldn't add a pull request template to modules. It is not going to be filled most of the time anyway, it is just a bother. I won't bother filling it myself.

Changes to modules usually aren't/shouldn't be complex enough to require such a detailed overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants