Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivers are doubled and path is disjointed #4

Closed
MortenHolmRep opened this issue Nov 16, 2017 · 11 comments
Closed

Rivers are doubled and path is disjointed #4

MortenHolmRep opened this issue Nov 16, 2017 · 11 comments
Assignees
Labels

Comments

@MortenHolmRep
Copy link

MortenHolmRep commented Nov 16, 2017

Summary: Rivers are doubled and path is disjointed
Version: Demo
Type: Bug (Rivers are doubled); Enhancement (path is disjointed)

Imported .svg to illustrator. Everything else seems fine but river segments are doubled and path disjointed

@Azgaar
Copy link
Owner

Azgaar commented Nov 19, 2017

Hi Volumunox,

Thanks for reporting! Not sure what is the root cause here. Will take a look

@MortenHolmRep
Copy link
Author

I suspect the disjointed path is due to the rivers narrowing, so each step increment in the river uses a new segment. I'm still a novice in regards to coding and don't know your code too well, but if the segment requires the previous line to make the new one, maybe a duplication error or mishap occurs when it tries to add the new line resulting in a double path.

@Azgaar
Copy link
Owner

Azgaar commented Nov 19, 2017

Yes, to make a narrowing line I split it into a small segments. The more correct variant is too draw a narrowed polygon, not a line, but I have to change a code a lot to implement it. And there is background shade element.

I don't have Illustrator and usually use Inkscape. In Inkscape it looks like supposed. Could you share a screenshot of its actual Illustrator look?

@MortenHolmRep
Copy link
Author

Sure can. This is freshly generated. As you can see from the first image, I highlighted the duplication.
In the second image i seperated the paths to see it visually.

1a
1b

@MortenHolmRep
Copy link
Author

This seemed like a better look, so uploading this as well :)

1c

@Azgaar
Copy link
Owner

Azgaar commented Nov 19, 2017

Thanks! It could be a element, that should not be displayed at all. And as I see background shadow is displayed as a simple line. I'm going to change the narrowed line to a polygon one day. And I will try to install Illustrator to check the svg correctness.

@Azgaar
Copy link
Owner

Azgaar commented Nov 20, 2017

Tried Illustrator, got the triplication of the river element. Not sure what is wrong, but definitely need to re-build river generation.

@Azgaar
Copy link
Owner

Azgaar commented Jan 15, 2018

Not sure I can fix it soon. Closing for a while

@Azgaar Azgaar closed this as completed Jan 15, 2018
@Azgaar Azgaar reopened this Jan 25, 2018
@Azgaar
Copy link
Owner

Azgaar commented Jan 25, 2018

I'd reworked river generation algorithm and planning to deploy it next week. This should fix the issue.

@Azgaar Azgaar self-assigned this Jan 25, 2018
@Azgaar
Copy link
Owner

Azgaar commented Feb 5, 2018

The issue is fixed, pending deployment (need to fix some non-related issues)

@Azgaar
Copy link
Owner

Azgaar commented Feb 6, 2018

The river rendering code is re-worked and the issue is not actual anymore. Please remove the old site from browser cache and check the new version

@Azgaar Azgaar closed this as completed Feb 7, 2018
mamokin referenced this issue in mamokin/Fantasy-Map-Generator Oct 22, 2018
Translate end-to-end_testing.md
goteguru pushed a commit to goteguru/Fantasy-Map-Generator that referenced this issue Sep 6, 2021
Dropbox support - basic implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants