Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debugger Cpu Load Issue #146

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix Debugger Cpu Load Issue #146

merged 1 commit into from
May 15, 2023

Conversation

mmkamron
Copy link
Contributor

Solves #135.

The issue was reproducible on my Linux machine as well. After running command with --debug option and accessing a public endpoint, CPU utilization increases instantly, in my case up to 220%. However, just closing source connection in bind function fixed the issue for me.

@azimjohn
Copy link
Owner

Thanks Kamron for your contribution!

Since bind() is called bi-directionally, it must have closed both connections in turn.
Anyways, it's okay to double close a connection than not closing at all.

2.1 binaries will be updates the new changes.

@azimjohn azimjohn merged commit 936e8dc into azimjohn:debugger May 15, 2023
@mmkamron mmkamron deleted the patch-1 branch May 16, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants