Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upload files to storage-api #327

Merged
merged 11 commits into from
Mar 13, 2023
Merged

feat: upload files to storage-api #327

merged 11 commits into from
Mar 13, 2023

Conversation

maxwelbm
Copy link
Contributor

  • upload files on storageapi

@maxwelbm maxwelbm marked this pull request as ready for review March 10, 2023 20:00
@maxwelbm maxwelbm requested a review from a team March 10, 2023 20:00
ftoldato
ftoldato approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@ftoldato ftoldato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice Job

PatrickMenoti
PatrickMenoti reviewed Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@PatrickMenoti PatrickMenoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to put Storage-API url in prod env file

@PatrickMenoti PatrickMenoti changed the title Feat upload storageapi feat: upload files to storage-api Mar 10, 2023
@maxwelbm
fix: versionID being caught before being built
954757f 
adjust the msm parameter being passed twice in the msm function, and passing it directly, added the storage path in the prod envs
@maxwelbm maxwelbm merged commit 972d87a into dev Mar 13, 2023
@maxwelbm maxwelbm deleted the feat-upload-storageapi branch March 13, 2023 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ftoldato ftoldato ftoldato approved these changes

@PatrickMenoti PatrickMenoti PatrickMenoti approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxwelbm @ftoldato @PatrickMenoti