Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new theme #192

Closed
wants to merge 4 commits into from
Closed

Added new theme #192

wants to merge 4 commits into from

Conversation

matteobelotti
Copy link
Contributor

No description provided.

@stockerman7
Copy link

NAVER - http://www.naver.com/

stockerman7@naver.com 님께 보내신 메일 <[PlainTasks] Added new theme (#192)> 이 다음과 같은 이유로 전송 실패했습니다.


받는 사람이 회원님의 메일을 수신차단 하였습니다.


@vovkkk
Copy link
Collaborator

vovkkk commented Nov 18, 2014

It doesn’t seem too different, maybe add these changes into tasks-eighties-dark @belmat @buildersbrewery

If you guys think it should be separate schemes, I wouldn’t mind but then you @belmat should add note in default settings files (all three of them) before merge.

@stockerman7
Copy link

NAVER - http://www.naver.com/

stockerman7@naver.com 님께 보내신 메일 <Re: [PlainTasks] Added new theme (#192)> 이 다음과 같은 이유로 전송 실패했습니다.


받는 사람이 회원님의 메일을 수신차단 하였습니다.


@ghost
Copy link

ghost commented Nov 18, 2014

Whatever works is fine with me.

@matteobelotti
Copy link
Contributor Author

The differences between two themes are only in the colors of some objects. I used it because i find it more clearly. If you prefer to upgrade the package is good for me, otherwise tell me what I need to do to complete commit.

@vovkkk
Copy link
Collaborator

vovkkk commented Nov 19, 2014

Let’s have both.
Simply add notice in default setting files

@matteobelotti
Copy link
Contributor Author

Is it ok? Or miss other change?
And, sorry for my commit with italian comment. But now i don't know how to change it.

@vovkkk vovkkk closed this in fe73b7c Nov 20, 2014
@vovkkk
Copy link
Collaborator

vovkkk commented Nov 20, 2014

You could run in terminal

git rebase -i head~4

It would open text editor with four lines started with pick you could replace them like this

r 6a46c90 Added new theme
f 2191473 Modificati setting linux
f 122942e Add notice theme
f 6e01424 Add notice theme

close file and save, when rebase finished—forced push, done. 😄

I already merged it, thank you for pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants