Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell] Introduce shell component #143

Merged
merged 1 commit into from Mar 1, 2021
Merged

[Shell] Introduce shell component #143

merged 1 commit into from Mar 1, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 22, 2021

closes #142

changelog:

  • added Psl\Shell\execute function
  • added Psl\Shell\escape_argument function
  • added Psl\Shell\escape_command function

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes. labels Feb 22, 2021
@azjezz azjezz self-assigned this Feb 22, 2021
@coveralls
Copy link

coveralls commented Feb 22, 2021 •
edited

Pull Request Test Coverage Report for Build 587727381

  • 34 of 34 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 99.96%
Totals Coverage Status
Change from base Build 585641872: 0.0005%
Covered Lines: 2522
Relevant Lines: 2523
💛 - Coveralls

@azjezz azjezz added this to the 1.5.0 milestone Feb 22, 2021
@azjezz azjezz force-pushed the feature/shell branch 2 times, most recently from 96694fe to 90d87ce Compare February 22, 2021 01:57
@azjezz
Copy link
Owner Author

azjezz commented Feb 22, 2021

so far, I'm satisfied with the API, i don't think we want to add anything more complex yet ( at least no until we have #127 ).

veewee
veewee reviewed Feb 22, 2021
View reviewed changes
src/Psl/Shell/execute.php Show resolved Hide resolved
src/Psl/Shell/execute.php Show resolved Hide resolved
src/Psl/Shell/execute.php Show resolved Hide resolved
src/Psl/Shell/execute.php Show resolved Hide resolved
src/Psl/Shell/execute.php Show resolved Hide resolved
@azjezz azjezz merged commit 81ab0ab into 1.5.x Mar 1, 2021
@azjezz azjezz deleted the feature/shell branch March 6, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee left review comments

Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Shell component
3 participants
@azjezz @coveralls @veewee