Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IO] Introduce IO component #127

Merged
merged 1 commit into from
Mar 19, 2021
Merged

[IO] Introduce IO component #127

merged 1 commit into from
Mar 19, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 16, 2021

No description provided.

@coveralls
Copy link

coveralls commented Feb 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 666707053

  • 118 of 118 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 664946666: 0.0%
Covered Lines: 2927
Relevant Lines: 2927
💛 - Coveralls

@azjezz azjezz added this to the 1.3.0 milestone Feb 16, 2021
veewee
veewee reviewed Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising. The interface system for stream handlers are far more superiour than PSR-7 streams! At the moment, I am not sure about all those combined interfaces, but they don't hurt anyone either ...

src/Psl/IO/Reader.php Show resolved Hide resolved
src/Psl/IO/input_handle.php Show resolved Hide resolved
src/Psl/Internal/suppress.php Show resolved Hide resolved
src/Psl/IO/Reader.php Show resolved Hide resolved
src/Psl/IO/Internal/open.php Show resolved Hide resolved
src/Psl/IO/CloseSeekReadWriteHandle.php Outdated Show resolved Hide resolved
@azjezz azjezz mentioned this pull request Feb 17, 2021
Closed
11 tasks
@azjezz azjezz self-assigned this Feb 17, 2021
@azjezz azjezz modified the milestones: 1.3.0, 1.4.0 Feb 17, 2021
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: In Progress This issue is being worked on, and has someone assigned. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes. labels Feb 17, 2021
@azjezz azjezz changed the base branch from 1.3.x to 1.4.x February 17, 2021 20:07
BackEndTea
BackEndTea reviewed Feb 18, 2021
View reviewed changes
src/Psl/IO/error_handle.php Outdated Show resolved Hide resolved
src/Psl/Internal/suppress.php Outdated Show resolved Hide resolved
@azjezz azjezz changed the base branch from 1.4.x to 1.5.x February 20, 2021 19:51
@azjezz azjezz modified the milestones: 1.4.0, 1.5.0 Feb 20, 2021
This was referenced Feb 22, 2021
Merged
Merged
@azjezz azjezz changed the title [IO] initial commit * Mar 2, 2021
@azjezz azjezz changed the title * [IO] Introduce IO component Mar 2, 2021
@azjezz azjezz force-pushed the feature/io branch 3 times, most recently from cd2de91 to e39d2e3 Compare March 2, 2021 19:02
@azjezz azjezz mentioned this pull request Mar 16, 2021
Closed
@azjezz azjezz force-pushed the feature/io branch 14 times, most recently from 362ce61 to bf2f664 Compare March 19, 2021 03:28
@azjezz azjezz merged commit 8e485ca into 1.5.x Mar 19, 2021
@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Mar 19, 2021
@azjezz azjezz deleted the feature/io branch March 19, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee left review comments

@BackEndTea BackEndTea BackEndTea left review comments

Assignees

@azjezz azjezz

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@azjezz @coveralls @veewee @BackEndTea