Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filesystem] Introduce filesystem component #144

Merged
merged 1 commit into from Mar 8, 2021
Merged

[Filesystem] Introduce filesystem component #144

merged 1 commit into from Mar 8, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 23, 2021

No description provided.

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes. labels Feb 23, 2021
@azjezz azjezz added this to the 1.5.0 milestone Feb 23, 2021
@azjezz azjezz self-assigned this Feb 23, 2021
@coveralls
Copy link

coveralls commented Feb 23, 2021 •
edited

Pull Request Test Coverage Report for Build 631333035

  • 167 of 167 (100.0%) changed or added relevant lines in 33 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.963%
Totals Coverage Status
Change from base Build 624738517: 0.002%
Covered Lines: 2706
Relevant Lines: 2707
💛 - Coveralls

@azjezz
Copy link
Owner Author

azjezz commented Feb 23, 2021 •
edited

@veewee this on the other hand, can replace symfony/filesystem 😛 ( apart from the writing to files part, that will come after we have File handles, which is the next step after #127 ) ( added Filesystem\write_file / Filesystem\read_file, these should be a replacement for file_put_contents/file_get_contents, fwrite/fread/fgets .. etc functions will later be replaced with handles, which replace resources )

veewee
veewee reviewed Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the missing tests, the implementations look good to me! nice one

@azjezz azjezz force-pushed the feature/filesystem branch 17 times, most recently from 9f7a7b0 to ac21fe2 Compare March 1, 2021 05:15
@azjezz
Copy link
Owner Author

azjezz commented Mar 1, 2021

#itWorksOnMyMachine

image

@azjezz azjezz force-pushed the feature/filesystem branch 4 times, most recently from 54da28e to 9321842 Compare March 1, 2021 06:30
@azjezz azjezz added Status: Review Needed The issue has a PR attached to it which needs to be reviewed. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Mar 1, 2021
@azjezz azjezz requested a review from veewee March 1, 2021 06:31
azjezz
azjezz commented Mar 1, 2021
View reviewed changes
phpunit.xml.dist Show resolved Hide resolved
@azjezz azjezz force-pushed the feature/filesystem branch 2 times, most recently from 82a0c8a to e7bd89c Compare March 5, 2021 11:46
veewee
veewee reviewed Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#itWorksOnMyMachine

image

Tested it as well on my mac and works. Sometimes github actions filesystem does some strange stuff. Got similar issues in other packages.

phpunit.xml.dist Show resolved Hide resolved
@azjezz azjezz force-pushed the feature/filesystem branch 4 times, most recently from d744413 to aee410f Compare March 8, 2021 06:10
@azjezz azjezz linked an issue Mar 8, 2021 that may be closed by this pull request
Filesystem component #141
Closed
@azjezz azjezz merged commit 3621bf2 into 1.5.x Mar 8, 2021
@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed. labels Mar 19, 2021
@azjezz azjezz deleted the feature/filesystem branch March 19, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee left review comments

@BackEndTea BackEndTea BackEndTea left review comments

Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Filesystem component
4 participants
@azjezz @coveralls @veewee @BackEndTea