Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Str] Add the ability to supply string encoding #55

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Sep 27, 2020

Add the ability to supply string encoding instead of detecting the encoding from the giving string.

falling back to the internal encoding, then 'UTF-8'.

Now Psl\Str can be complete replacement for mb_str* and str* functions 🎉

@azjezz azjezz self-assigned this Sep 27, 2020
@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes. labels Sep 27, 2020
@azjezz azjezz added this to the v1.0.0 milestone Sep 27, 2020
@coveralls
Copy link

coveralls commented Sep 27, 2020

Pull Request Test Coverage Report for Build 518

  • 88 of 88 (100.0%) changed or added relevant lines in 38 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 512: 0.0%
Covered Lines: 1663
Relevant Lines: 1663

💛 - Coveralls

@azjezz azjezz force-pushed the feature/string-encoding branch 4 times, most recently from 08728c6 to 467c614 Compare September 27, 2020 14:21
@azjezz azjezz changed the title [Str] add ability to supply string encoding and use internal encodig instead of string encoding by default [Str] Add the ability to supply string encoding Sep 27, 2020
@azjezz azjezz merged commit 25480b4 into develop Sep 27, 2020
@azjezz azjezz deleted the feature/string-encoding branch September 27, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants