Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probes from the podTemplate to the podSpec #2777

Merged
merged 1 commit into from Feb 26, 2021

Conversation

aditya1105
Copy link
Contributor

Probes are static in nature and hence if they are present in the pod template, they should be added to the actual pod spec during dispatch.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2777 (e0d8505) into master (f49d865) will decrease coverage by 0.40%.
The diff coverage is 33.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2777      +/-   ##
============================================
- Coverage     40.08%   39.67%   -0.41%     
- Complexity     3872     4159     +287     
============================================
  Files           519      569      +50     
  Lines         35023    37506    +2483     
  Branches       4137     4365     +228     
============================================
+ Hits          14038    14882     +844     
- Misses        19798    21380    +1582     
- Partials       1187     1244      +57     
Impacted Files Coverage Δ Complexity Δ
az-core/src/main/java/azkaban/Constants.java 23.07% <0.00%> (-4.20%) 1.00 <0.00> (ø)
...c/main/java/azkaban/executor/ExecutionFlowDao.java 61.68% <0.00%> (-1.18%) 29.00 <0.00> (ø)
...main/java/azkaban/executor/ExecutorApiGateway.java 84.05% <ø> (ø) 16.00 <0.00> (ø)
...main/java/azkaban/executor/JdbcExecutorLoader.java 16.85% <0.00%> (-0.20%) 3.00 <0.00> (ø)
...azkaban/imagemgmt/daos/ImageMgmtCommonDaoImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/azkaban/imagemgmt/dto/DeleteResponse.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...aban/imagemgmt/dto/ImageRampupPlanResponseDTO.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...imagemgmt/dto/ImageVersionMetadataResponseDTO.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...zkaban/imagemgmt/dto/ImageVersionUsageDataDTO.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ban/imagemgmt/exception/ImageMgmtDaoException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10a022...e0d8505. Read the comment docs.

sshardool
sshardool previously approved these changes Feb 26, 2021
Copy link
Collaborator

@sshardool sshardool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change.
The static pod-template-merge you added earlier is quite handy. Nice work!

Copy link
Contributor

@jakhani jakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have designed this templatization part very nicely. It is very neat and clean approach. Thank you!

Copy link
Contributor

@jakhani jakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So neat! Thank you for fixing it.

@aditya1105 aditya1105 merged commit 8024fad into azkaban:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants