New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add probes from the podTemplate to the podSpec #2777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2777 +/- ##
============================================
- Coverage 40.08% 39.67% -0.41%
- Complexity 3872 4159 +287
============================================
Files 519 569 +50
Lines 35023 37506 +2483
Branches 4137 4365 +228
============================================
+ Hits 14038 14882 +844
- Misses 19798 21380 +1582
- Partials 1187 1244 +57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change.
The static pod-template-merge you added earlier is quite handy. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have designed this templatization part very nicely. It is very neat and clean approach. Thank you!
azkaban-common/src/main/java/azkaban/executor/container/KubernetesContainerizedImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So neat! Thank you for fixing it.
Probes are static in nature and hence if they are present in the pod template, they should be added to the actual pod spec during dispatch.