Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apple silicon arm #3115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

apple silicon arm #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db96491
working example for apple silicon without running in rosetta mode
Jun 25, 2022
8b9db68
works with arm version of node and npm
Jun 25, 2022
1651195
put back dependency that was temporarily removed
Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions az-exec-util/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ apply plugin: 'c'
model {
components {
main(NativeExecutableSpec) {
targetPlatform "osx_x86-64"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also a TODO? I'm not expert with Gradle, but does this sett the target platform regardless of what the current platform is?

Copy link
Author

@jeffsteinmetz jeffsteinmetz Aug 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about gradle either. all the Gradle docs state is "Specifies the names of one or more [Flavor] that this component should be built for."

I think this forces the build to x86 vs ARM so that it runs Azkaban in rosetta mode on ARM / apple silicon.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now see it only applies to a "c" utility in az-exec-util. I think it just makes the utility written in C build for x86, so the util will run in rosetta mode on ARM.
There may be a way to get that utility written in C to work on ARM, but that was beyond the scope of what I was able to pull together for this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was wondering what happens on other than osx platforms. Seems that this doesn't ruin it for them, at least the Travis build seems to have succeeded past the point of building az-exec-util.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are welcome to fork this and create a different MR if you can get everything else to work. I just put this MR here for posterity for anyone else having apple silicon / ARM issues.

sources {
c {
source {
Expand Down
6 changes: 3 additions & 3 deletions azkaban-web-server/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ buildscript {
// manage NodeJS distributions, use them from there.
// ***npm install*** installs all dependencies in package.json. It will only run when changes are made to package.json
plugins {
id "com.moowork.node" version "1.2.0"
id "com.github.node-gradle.node" version "3.3.0"
}

node {
// Version of node to use.
version = '8.10.0'
version = '16.15.1'

// Version of npm to use.
npmVersion = '5.6.0'
npmVersion = ''

// Base URL for fetching node distributions (change if you have a mirror).
distBaseUrl = 'https://nodejs.org/dist'
Expand Down
Loading