Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-email-errors] Email errors inline or attached #416

Closed
wants to merge 1 commit into from

Conversation

kaneda
Copy link

@kaneda kaneda commented Mar 24, 2015

- Updated azkaban#308 to take in a max lines, so that inline emails don't exceed 5 errors by default
- Ensure that these settings default to off
@kaneda
Copy link
Author

kaneda commented Mar 24, 2015

@erwa This should be a lot safer in all cases. The features default to off and there's a default max amount of errors to give in the inline message.

I also took the liberty of reformatting this to style best practices and removed the import .* (I personally don't like this at all, not for efficiency but for readability reasons)

@kaneda
Copy link
Author

kaneda commented Mar 30, 2015

@erwa could take a look at this when you get a sec?

@kaneda
Copy link
Author

kaneda commented Apr 5, 2015

@erwa any chance you could take a peak at this when you get a moment?

@kaneda
Copy link
Author

kaneda commented Apr 6, 2015

@davidzchen could you take a peak when you get a sec?

@kaneda
Copy link
Author

kaneda commented Apr 27, 2015

@davidzchen / @erwa any chance you could look at this?

@kaneda kaneda closed this Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant