adding execute-as-user feature. refer to documentation on usage details #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also see #517 for previous comments and feedbacks |
| @@ -0,0 +1,121 @@ | |||
| /* | |||
| * Copyright 2015 LinkedIn Corp. | |||
There was a problem hiding this comment.
Are we building this? I don't see any changes to build files.
If so, perhaps it shouldn't be in resources but rather in one of the standard directories according to Gradle's docs on building native binaries?
There was a problem hiding this comment.
We should also document building and setup for this c file
There was a problem hiding this comment.
Given that this is built as part of Azkaban and given that Gradle supports building native code, I think building this C file should be handled by the build system and we would not need to document how to build this file separately.
johnyu0520
pushed a commit
to johnyu0520/azkaban
that referenced
this pull request
Oct 20, 2015
…ld file in C, so have not made that change yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot cleaner commit messages.
Thanks to David Chen for all the tips and tricks!