This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Allow changing bot avatar #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! Yeah, I can foresee avatar being a more useful feature in the near future. I think the Mumble team is thinking about redoing the chat system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
avataroption to the config file. The option specifies the path to an image that the bot will use as its avatar on the Mumble server.Note: The comment added to the example config points out a limit of 128 KB for the avatar image, but I think this limit is adjustable using the
imagemessagelengthoption in the Murmur configuration. I'm also not completely sure which file formats are supported by Mumble, but PNG seems to work.Additionally, this setting is currently completely independent from the image shown on the Flask web interface. If a user wanted to change that image then I assume they would need to replace the appropriate file under /static/image.