Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unexpected API Change in Pixabay Causes Video Module Failure #122

Closed
2 tasks done
azrael8576 opened this issue Apr 17, 2024 · 0 comments · Fixed by #125
Closed
2 tasks done

[Bug]: Unexpected API Change in Pixabay Causes Video Module Failure #122

azrael8576 opened this issue Apr 17, 2024 · 0 comments · Fixed by #125
Assignees
Labels
bug Something isn't working triage me Indicates that this issue or PR needs evaluation and categorization.

Comments

@azrael8576
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

When attempting to use the Video module, the API call failed unexpectedly. The issue appears to stem from a recent API change at Pixabay, leading to a MissingFieldException for the picture_id field.

This field was expected but missing, indicating that the API's expected response format might have been altered.
The expected behavior was the successful retrieval of video data without any exceptions.

Relevant logcat output

Error(endOfPaginationReached=false, error=kotlinx.serialization.MissingFieldException: Field 'picture_id' is required for type with serial name 'com.wei.picquest.core.network.model.NetworkVideoDetail', but it was missing at path: $.hits[0])
@azrael8576 azrael8576 added bug Something isn't working triage me Indicates that this issue or PR needs evaluation and categorization. labels Apr 17, 2024
@azrael8576 azrael8576 self-assigned this Apr 17, 2024
azrael8576 added a commit that referenced this issue Apr 17, 2024
…field, remove 'picture_id' (fixed #122)

Adjusted the video module's data model to match Pixabay's updated API response. Removed the outdated 'picture_id' field and added 'thumbnail' fields to prevent errors and ensure smooth operation.
azrael8576 added a commit that referenced this issue Apr 17, 2024
…field, remove 'picture_id' (fixed #122)

Adjusted the video module's data model to match Pixabay's updated API response. Removed the outdated 'picture_id' field and added 'thumbnail' fields to prevent errors and ensure smooth operation.
azrael8576 added a commit that referenced this issue Apr 17, 2024
…field, remove 'picture_id' (fixed #122)

Adjusted the video module's data model to match Pixabay's updated API response. Removed the outdated 'picture_id' field and added 'thumbnail' fields to prevent errors and ensure smooth operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage me Indicates that this issue or PR needs evaluation and categorization.
Projects
None yet
1 participant