Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/35/envman demo prep #107

Merged
merged 44 commits into from
Apr 3, 2023
Merged

Feature/35/envman demo prep #107

merged 44 commits into from
Apr 3, 2023

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Apr 3, 2023

Part of #35.

Get envman example demo ready.

@azriel91
Replace .inc with .tick for item spec state current progress.
3e5c3a5
@azriel91
Replace .inc with .tick for item spec state desired progress.
444e1c6
@azriel91
Re-discover states current after states ensured.
062cd62
@azriel91
Update file download item spec to read ETag from memory.
740a77c
@azriel91
Discover states after cleaning up.
9eaae60
@azriel91
Don't rediscover states after applying.
b147141
@azriel91
Set state applied in ItemSpecWrapper::ensure_prepare.
85adbdc 
This helps the interrupted execution still store discovered state.
@azriel91
Move ProgressTracker reset code into ProgressTracker.
461f166
@azriel91
Hack: Pass errors out of ApplyCmd.
ce459d5
@azriel91
Hack: Try and surface AWS error description.
74f045e
@azriel91
Add AWS error description to other peace_aws item specs.
50f83ef
@azriel91
Remove cause chain from graphical report handler.
fe392be
@azriel91
Don't print states if apply returns any errors.
cec9a51
@azriel91
Try and explicitly end progress rendering.
6fede1d
@azriel91
Revert "Try and explicitly end progress rendering."
e321834 
This reverts commit 6fede1d.
@azriel91
Hide progress bar target in CliOutput::progress_end.
baea9f3
@azriel91
Don't hide progress bars when command finishes.
ad8cc3b
@azriel91
Change StatesDiscoverCmd to discover current, desired, or both vari…
a0f5793 
…ants.
@azriel91
Show more detail in EnvCleanCmd.
c52f13c
@azriel91
Add spacing between end of progress bars and next output.
d118522
@azriel91
Add cmd consolidation idea to ideas.md.
e6fea7f
@azriel91
Add # Errors heading.
7f8f769
@azriel91
Show error message from one nested level in ApplyCmd.
dfa51ba
@azriel91
Rename app_cycle to envman.
dc57472
@azriel91
Update envman states to include AWS URLs.
27e1a48
@azriel91
Add padding to states display.
50de0fe
@azriel91
Shorten item spec IDs and param keys.
03fb5af
@azriel91
Shorten S3 bucket discover error message.
4323152
@azriel91
Remove incorrect command hint from file download error.
83d2f21
@azriel91
Store the timestamp that S3 bucket is created.
40a9fa5 
This allows for a better state desired display message.
@azriel91
Initialize ProgressBar length to 0, so spinners render as complete …
70c913d 
…bars when finished.
@azriel91
Revert "Initialize ProgressBar length to 0, so spinners render as c…
2f70009 
…omplete bars when finished."

This reverts commit 70c913d.
@azriel91
Move progress bar finish and abandon logic from CliOutput into `Pro…
3e05e36 
…gress`.
@azriel91
Hardcode bar and spinner completion renderings.
7648472
@azriel91
Revert "Move progress bar finish and abandon logic from CliOutput i…
cfbfef7 
…nto `Progress`."

This reverts commit 3e05e36.
@azriel91
Hack StatesDiscoverCmd to discover states concurrently.
65df805
@azriel91
Always return desired state for IamRole item spec to improve displa…
718a49f 
…y message.
@azriel91
Serialize states_desired in ApplyCmd.
fb96f7f
@azriel91
Update state display text.
6b50b0c
@azriel91
Return Result<CmdCtx<..>, E> for EnsureCmd::exec_dry and `CleanCm…
c589442 
…d::exec_dry`.
@azriel91
Update workspace tests to compile.
fa14030
@azriel91
Address clippy lints.
bac7ef6
@azriel91
Use "output_progress" instead of "output_colorized" for constants.
8aa40fb
@azriel91
Update CHANGELOG.md.
5ed8972
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +1.68 🎉

Comparison is base (e52cb13) 91.30% compared to head (5ed8972) 92.99%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   91.30%   92.99%   +1.68%     
==========================================
  Files         285      276       -9     
  Lines       21134    21006     -128     
==========================================
+ Hits        19296    19534     +238     
+ Misses       1838     1472     -366
Impacted Files Coverage Δ
crate/rt_model/src/outcomes.rs 50.00% <ø> (ø)
crate/rt_model/src/outcomes/cmd_outcome.rs 0.00% <0.00%> (ø)
crate/rt/src/cmds/sub/apply_cmd.rs 75.22% <63.09%> (-2.90%) ⬇️
crate/rt_model_native/src/output/cli_output.rs 86.91% <70.58%> (+0.20%) ⬆️
crate/rt/src/cmds/states_discover_cmd.rs 71.18% <70.61%> (-28.82%) ⬇️
crate/core/src/progress/progress_tracker.rs 100.00% <100.00%> (ø)
crate/rt/src/cmds/clean_cmd.rs 100.00% <100.00%> (ø)
crate/rt/src/cmds/ensure_cmd.rs 100.00% <100.00%> (ø)
crate/rt/src/progress.rs 92.50% <100.00%> (-0.36%) ⬇️
crate/rt_model/src/item_spec_wrapper.rs 83.94% <100.00%> (+0.24%) ⬆️
... and 6 more

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 marked this pull request as ready for review April 3, 2023 05:37
@azriel91 azriel91 merged commit 268afc6 into main Apr 3, 2023
@azriel91 azriel91 deleted the feature/35/envman-demo-prep branch April 3, 2023 05:37
@azriel91 azriel91 mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azriel91