Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added source_image_id support for linux/windows vm #293

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

jorseng
Copy link
Contributor

@jorseng jorseng commented Feb 25, 2021

Currently the custom image resource is not yet available in caf module, thus no local combined objects is being passed to the variable var.custom_image_ids

@jorseng jorseng self-assigned this Feb 25, 2021
@jorseng jorseng linked an issue Feb 25, 2021 that may be closed by this pull request
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good contribution @jorseng can you please add examples and CI examples?

@arnaudlh arnaudlh added the enhancement New feature or request label Mar 4, 2021
@arnaudlh arnaudlh added this to In progress in Milestone 2103 via automation Mar 4, 2021
Milestone 2103 automation moved this from In progress to Reviewer approved Mar 11, 2021
@arnaudlh arnaudlh merged commit 70db9b1 into master Mar 11, 2021
Milestone 2103 automation moved this from Reviewer approved to Done Mar 11, 2021
@arnaudlh arnaudlh deleted the js-vm-custom-img branch March 11, 2021 11:07
@arnaudlh arnaudlh changed the title added source_image_id support for linux/windows vm Added source_image_id support for linux/windows vm Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Create Windows and Linux VM with Custom Image
2 participants