Add support for updates to resource type(s) with auto-upgrade support #203
+438
−114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owen Farrell owen.farrell@gmail.com
Fixes #140
Supercedes: #196
PR Checklist
resourceDefinition.json
models_generated.go
file in my PR)Description
Does this introduce a breaking change
While this doesn't inherently introduce a backwards-breaking change, I'm not sure that my attempt at an auto-upgrade is a sure thing. The approach that I used was a bit of a "guess and check" based on the existing outputs. In a worst case scenarios, anyone who attempts to auto-upgrade will incur the existing behavior (a forced deletion/recreation of downstream resources) one last time. Any suggestions on how to mitigate this issue would be appreciated.
Testing
In addition to local unit testing, I've exercised these updates via a local provider override and it seems to meet the need.