Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api from rql datetime #7

Open
nuxlli opened this issue Sep 13, 2013 · 4 comments
Open

Add api from rql datetime #7

nuxlli opened this issue Sep 13, 2013 · 4 comments

Comments

@nuxlli
Copy link
Member

nuxlli commented Sep 13, 2013

No description provided.

@dbettin
Copy link

dbettin commented Sep 16, 2013

What is your plan for the datetime(s)? Are you looking at some of the new and upcoming elixir libraries?

@nuxlli
Copy link
Member Author

nuxlli commented Sep 16, 2013

At the moment this is not the idea, on the other hand could have come to be an abstraction future, including the https://github.com/alco/elixir-datetime, watching to see how it goes these implementations.

For now would just implement the interface datatime the RQL: http://www.rethinkdb.com/api/#js:dates_and_times-now

@dbettin
Copy link

dbettin commented Sep 16, 2013

The default drivers all store the datetime(s) in their respective native types; I would assume this driver would do the same.

What is your timeline for starting work on this?

Again, thanks for the great library!

@nuxlli
Copy link
Member Author

nuxlli commented Sep 16, 2013

You're right, had not yet watched it.

Therefore I believe that the most feasible way is to use the elixir-datetime, do not know if there were any plans to make this part of the elixir standard library's, but either way future adjustments should be simple of implement.

On the other hand I have tried to keep the driver as pure as possible, avoiding dependence on third parties. I've been looking at the code https://github.com/exlir-lang/ecto, and in case they support the datetime is very simple and was done with simple records: https://github.com/elixir-lang/ecto/blob/master/lib/ecto.ex

I have no plans to work on this feature for now, my focus is on the use of the driver in another project, and perhaps one of rethinkdb adapter for ecto. Feel free to contribute to this part if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants