Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong tag/branch chosen #12

Closed
tarfu opened this issue Jan 21, 2015 · 3 comments
Closed

wrong tag/branch chosen #12

tarfu opened this issue Jan 21, 2015 · 3 comments
Assignees
Milestone

Comments

@tarfu
Copy link
Contributor

tarfu commented Jan 21, 2015

Hi,

i recognized that https://azul3d.org/semver.v1?go-get=1 points to the wrong tag.

it points to the tag v1 but there is a tag v1.0.1 which would be the one to choose.
I will try to commit a fix myself.

My version of semver is v2.

Regards,

Tobias

@slimsag slimsag added this to the 2.0.1 milestone Jan 21, 2015
@slimsag slimsag self-assigned this Jan 21, 2015
@slimsag
Copy link
Owner

slimsag commented Jan 21, 2015

Good news!

The tests I've just added also find that sorting of git refs is actually reversed! This means it would have always chosen the least greatest version in the same major version (e.g. v1 over v1.2, but not v1 over v2).

slimsag added a commit that referenced this issue Jan 21, 2015
Fix incorrect git ref version choices; See #12
@tarfu
Copy link
Contributor Author

tarfu commented Jan 21, 2015

Had fixed this as well but forgot to push it, sry .

If you haven't fixed it til I get home I will push it as well.

Tobias
Am 21.01.2015 21:51 schrieb "Stephen Gutekanst" notifications@github.com:

Good news!

The tests I've just added also find that sorting of git refs is actually
reversed
! This means it would have always chosen the least greatest
version in the same major version (e.g. v1 over v.1.2).


Reply to this email directly or view it on GitHub
#12 (comment).

@slimsag
Copy link
Owner

slimsag commented Jan 21, 2015

Everything should be good now. I've released v2.0.1 and it's up and running at azul3d.org.

go get azul3d.org/semver.v1 now properly checks out v1.0.1

Cheers =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants