Fix incorrect git ref version choices; See #12 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting with always the same Version does not really make sense. We parsed the version for the ref but never used it for sorting or anything else but for choosing if it is the right major version
|
I really appreciate you tracking this down. I will try my best to get 2.0.1 out by today. I am going to see if I can make some tests before merging this to identify when it fails so this doesn't occur in the future. |
slimsag
changed the title
slimsag
added a commit
that referenced
this pull request
Jan 21, 2015
Fix incorrect git ref version choices; See #12
|
Please also see http://azul3d.org/doc/contributing.html#attribution, if you would like to be properly attributed for you work here (which I really appreciate, by the way!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting with always the same Version does not really make sense.
We parsed the version for the ref but never used it for sorting or anything else but for choosing if it is the right major version