Skip to content

Commit

Permalink
Sync eng/common directory with azure-sdk-tools for PR 8463 (Azure#23089)
Browse files Browse the repository at this point in the history
* Fix case where changelog wasn't marked as invalid

* Update CHANGELOG.md

---------

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
  • Loading branch information
3 people committed Jun 18, 2024
1 parent 955e5aa commit a3757a7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions eng/common/scripts/ChangeLog-Operations.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ function Remove-EmptySections {
{
$parsedSections = $ChangeLogEntry.Sections
$sanitizedReleaseContent = New-Object System.Collections.ArrayList(,$releaseContent)
foreach ($key in @($parsedSections.Keys))

foreach ($key in @($parsedSections.Keys))
{
if ([System.String]::IsNullOrWhiteSpace($parsedSections[$key]))
{
Expand Down Expand Up @@ -442,9 +442,10 @@ function Confirm-ChangeLogForRelease {
if (!$foundRecommendedSection)
{
$ChangeLogStatus.Message = "The changelog entry did not contain any of the recommended sections ($($RecommendedSectionHeaders -join ', ')), please add at least one. See https://aka.ms/azsdk/guideline/changelogs for more info."
$ChangeLogStatus.IsValid = $false
if (!$SuppressErrors) {
LogError "$($ChangeLogStatus.Message)"
}
}
return $ChangeLogStatus.IsValid
}
}
1 change: 1 addition & 0 deletions sdk/template/aztemplate/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 0.6.0 (2024-03-14)

### Features Added
* Template package validating release pipeline

## 0.1.0 (2021-12-02)
Expand Down

0 comments on commit a3757a7

Please sign in to comment.