-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Serialization #50
base: main
Are you sure you want to change the base?
Conversation
Undo renaming of class JsonObject in order to merge upstream.
Merge Upstream
Merged Upstream!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See some of my comments, there are some things that should be addressed. Additionally, this is complex enough that it needs comments and javadocs.
@@ -1,2 +1,2 @@ | |||
# Contributing to Azurite | |||
[https://azurite-engine.github.io/Azurite-Docs/docs/contributing.html](https://azurite-engine.github.io/Azurite-Docs/docs/contributing.html) | |||
[https://azurite-engine.github.io/Azurite-Docs/docs/contributing.html](https://www.youtube.com/watch?v=dQw4w9WgXcQ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that link... this is actually an important link to the docs, it shouldn't be a troll.
@@ -5,7 +5,8 @@ | |||
import java.util.Arrays; | |||
import java.util.List; | |||
|
|||
public class JSONObject { | |||
@Deprecated | |||
public class JSONObjectOld { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecation or outright removal are all that is necessary here.
Currently there are no JavaDocs
I'm gonna add them later