JSON Serialization #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athaun
added
Review todo
Undo renaming of class JsonObject in order to merge upstream.
Merge Upstream
Merged Upstream!
athaun
requested changes
Mar 29, 2022
| @@ -1,2 +1,2 @@ | |||
| # Contributing to Azurite | |||
| [https://azurite-engine.github.io/Azurite-Docs/docs/contributing.html](https://azurite-engine.github.io/Azurite-Docs/docs/contributing.html) | |||
| [https://azurite-engine.github.io/Azurite-Docs/docs/contributing.html](https://www.youtube.com/watch?v=dQw4w9WgXcQ) | |||
There was a problem hiding this comment.
I know that link... this is actually an important link to the docs, it shouldn't be a troll.
| @@ -5,7 +5,8 @@ | |||
| import java.util.Arrays; | |||
| import java.util.List; | |||
|
|
|||
| public class JSONObject { | |||
| @Deprecated | |||
| public class JSONObjectOld { | |||
There was a problem hiding this comment.
deprecation or outright removal are all that is necessary here.
athaun
added
good first issue
athaun
added
needs more work
and removed
In review process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are no JavaDocs
I'm gonna add them later