Add National Day of Mourning for Australia #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures appear to be related to the UK test cases where the holiday type has changed from TYPE_OBSERVANCE to TYPE_BANK but the test cases do not take this into account. This would need to be fixed by an additional PR? |
|
@FuzzyWuzzyFraggle Yes indeed there are some errors with the UK tests. I will fix those shortly. |
|
@FuzzyWuzzyFraggle The UK tests have been fixed, so you may want to rebase your branch. (Note: it possible some failures pop up as tests are randomized and maybe not all cases are covered properly). |
|
Since this pull request has not had any activity within the last 90 days, I have marked it as stale. |
stelgenhof
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new national public holiday for Australia in commemoration of Queen Elizabeth II
Based on recent PR by freshleafmedia for UK holiday