Skip to content

Commit

Permalink
Fix slack messages for todo updates and addition (#765)
Browse files Browse the repository at this point in the history
* Fix slack messages for todo updates and addition

* Fix linting

* Zip new old todos instead of indexing old todos

Co-authored-by: Aditya Bharadwaj <aditya@b12.io>
  • Loading branch information
adbharadwaj and Aditya Bharadwaj committed Mar 31, 2021
1 parent 2e5e0d6 commit 4e89d6e
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions orchestra/todos/views.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import copy

from django.contrib import messages
from django.contrib.admin.views.decorators import staff_member_required
Expand All @@ -12,6 +13,7 @@
from rest_framework.response import Response
from rest_framework.decorators import action
from jsonview.exceptions import BadRequest
from django.db.models.query import QuerySet

from orchestra.core.errors import TodoListTemplateValidationError
from orchestra.models import Task
Expand Down Expand Up @@ -178,16 +180,22 @@ def patch(self, request, *args, **kwargs):
return self.put(request, *args, **kwargs)

def perform_update(self, serializer):
todo = serializer.save()
if isinstance(todo, Todo):
old_todo = self.get_object()
notify_single_todo_update(
self.request.user, old_todo, todo)
old_data = copy.deepcopy(serializer.instance)
old_todos = list(old_data) if isinstance(
old_data, QuerySet) else [old_data]
data = serializer.save()
todos = data if isinstance(data, list) else [data]
for old_todo, new_todo in zip(old_todos, todos):
if isinstance(new_todo, Todo):
notify_single_todo_update(
self.request.user, old_todo, new_todo)

def perform_create(self, serializer):
todo = serializer.save()
if isinstance(todo, Todo):
notify_todo_created(todo, self.request.user)
data = serializer.save()
todos = data if isinstance(data, list) else [data]
for todo in todos:
if isinstance(todo, Todo):
notify_todo_created(todo, self.request.user)


class TodoViewset(GenericTodoViewset):
Expand Down

0 comments on commit 4e89d6e

Please sign in to comment.