Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker batch size and request frequency to StaffBot #346

Merged
merged 3 commits into from Aug 8, 2016

Conversation

marcua
Copy link
Member

@marcua marcua commented Aug 6, 2016

No description provided.

@@ -62,7 +62,7 @@ def __init__(self, **kwargs):
default_config = getattr(settings, 'STAFFBOT_CONFIG', {})
default_config.update(kwargs)
token = settings.ORCHESTRA_SLACK_STAFFBOT_TOKEN
super().__init__(token, **kwargs)
super().__init__(token, **default_config)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unrelated to this PR, but I think it's a bug to send kwargs instead of default_config in. @joshblum or @kkamalov any ideas?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it :/

@joshblum
Copy link
Collaborator

joshblum commented Aug 8, 2016

lgtm :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.458% when pulling 20a0ac8 on staffing-parameters into ee897c8 on master.

@marcua marcua merged commit 08b7f55 into master Aug 8, 2016
@marcua marcua deleted the staffing-parameters branch August 8, 2016 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants