Speedup test suite by using weak hash algo #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default password hasher is slow by design and the test suite creates many users. Relevant doc: https://docs.djangoproject.com/en/1.9/topics/testing/overview/#password-hashing On my laptop, repeated `time make test` goes from ~110s to ~58s.
| @@ -130,4 +130,9 @@ | |||
| STATIC_URL = '/static/' | |||
| STATIC_ROOT = 'staticfiles' | |||
|
|
|||
|
|
|||
| TESTING = sys.argv[1:2] == ['test'] | |||
There was a problem hiding this comment.
Why a slice here and not just look at sys.argv[1]?
There was a problem hiding this comment.
i think because he doesn't check the length, a slice will always return an empty array
|
Unfortunately CI fails, seemingly because it cannot push coverage report. |
|
@vhf yeah it's a bug with coveralls :/, just submitted TheKevJames/coveralls-python#115 to ask about it. We can review and manually test for the time being, thanks for the contributions!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default password hasher is slow by design, which in turn usually slows down test user creation quite a bit. Relevant doc: https://docs.djangoproject.com/en/1.9/topics/testing/overview/#password-hashing
On my laptop, repeated
time make testgoes from >110s to <60s.