Updates hijack banner styles to be cleaner and collapsible. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcua
reviewed
Nov 21, 2020
| @@ -74,3 +74,124 @@ $main-font-stack: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helveti | |||
| transform:rotate(360deg); | |||
There was a problem hiding this comment.
sanity-checking we should be updating timer.css (maybe) and orchestra.css (probably)
There was a problem hiding this comment.
I think all are necessary to render the various pages. I updated _common.scss to make sure the css was loaded on every page, and gulp did the rest.
marcua
reviewed
Nov 21, 2020
| @@ -74,3 +74,124 @@ $main-font-stack: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helveti | |||
| transform:rotate(360deg); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
does the time-tracking modal and each screen from the top right menu (e.g., account settings, projman, ...) still display properly?
There was a problem hiding this comment.
Yes! Sent you a video walkthrough offline to confirm.
thisisdhaas
force-pushed
the
fix-hijack-notification
branch
from
12e386c
to
5729af9
Compare
thisisdhaas
force-pushed
the
fix-hijack-notification
branch
from
09b58af
to
4764d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blast from the past! This PR applies nicer hijack styles to our hijack banner, so it can be hidden (now to a thin but visible line) without refreshing the page, and re-expanded easily.
Since 2020, I applied some tiny style updates to optimize for mobile. Here is the latest look: