Show task submit button only to project admins #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcua
reviewed
Jan 17, 2023
| @@ -114,7 +114,8 @@ <h3 class="modal-title">{{command | capitalize}} Confirmation</h3> | |||
| <div class="container-fluid"> | |||
There was a problem hiding this comment.
This is great! Just so we don't confuse new users, we'll want to make sure we create the group and add it to the sample workflow data:
- Our docs list the accounts that are created
- This script does the loading
- I think the fix is to
from django.contrib.auth.models import Groupat the top of the script and add something like
project_admins = Group.objects.get_or_create(name='project_admins')
project_admins.user_set.add(user)
after this line
added 2 commits
January 19, 2023 17:32
marcua
approved these changes
Jan 20, 2023
marcua
requested changes
Jan 20, 2023
simple_workflow/load_sample_data.py
Outdated
| project_admins.user_set.add(user) | ||
| project_admins, created = Group.objects.get_or_create( | ||
| name='project_admins') | ||
| if created: |
There was a problem hiding this comment.
even if the group already existed, we should add the user to the group
| project_admins.user_set.add(user) | ||
| project_admins, created = Group.objects.get_or_create( | ||
| name='project_admins') | ||
| if created: |
marcua
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that task submit button is only visible to project admins now.