New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about strtolower #7

Closed

ayacoo opened this issue Jan 3, 2021 · 0 comments

ayacoo commented Jan 3, 2021

https://github.com/b13/justincase/blob/master/src/Middleware/LowerCaseUri.php#L35

Should we perhaps change strtolower to multibyte? I have a similar solution here and unfortunately also umlauts, so that was necessary.

PS: I didn't know about your extension until now, otherwise I would have used this ;-)

bmack closed this as completed in

cd9cc1d

infabo added a commit to infabo/justincase that referenced this issue


          [FIX] use mb_strtolower

d9690e8

see b13#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment