[BUGFIX] Set fieldname in categories relations #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 15, 2014 14:28
In TYPO3 6.2, a table may have several categories fields. It is thus necessary to set values for the "fieldname" field when filling the "sys_category_record_mm" table.
The task that migrates the DAM category relations makes two critical mistakes: * the uid_local and uid_foreign fields are inverted (sys_category is local, sys_file is foreign) * the table with the categories relation is sys_file_metadata and not sys_file anymore.
In the backend, FAL references are ordered using the sorting_foreign field of sys_file_reference and not sorting. As such the migration task should fill the sorting_foreign field instead of sorting. Furthermore, the relevant order from tx_dam_mm_ref is also sorting_foreign instead of sorting.
The MigrateRelations service checks if a given relation has already been migrated, by querying the sys_file_reference table. But it doesn't take the fieldname parameter into account which means that it will ignore relations to the same file but from a different field in the same table.
bmack
added a commit
that referenced
this pull request
Apr 15, 2014
[BUGFIX] Set fieldname in categories relations
|
Brilliant, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TYPO3 6.2, a table may have several categories fields.
It is thus necessary to set values for the "fieldname" field
when filling the "sys_category_record_mm" table.