Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of usage for PDF creation incorrect #6

Closed
rintisch opened this issue Aug 19, 2020 · 2 comments
Closed

Description of usage for PDF creation incorrect #6

rintisch opened this issue Aug 19, 2020 · 2 comments

Comments

@rintisch
Copy link
Contributor

In the README.md its said

$absolutepathToFile = $pdfService->saveToFile('myPdf.pdf'); (line 35)

This leads to a file named myPdf.pdf.pdf.

To it need to be

$absolutepathToFile = $pdfService->saveToFile('myPdf');

@rintisch
Copy link
Contributor Author

I will create a pull request for this issue

@rintisch
Copy link
Contributor Author

I realized that adding the file format (.pdf) is necessary when using the function $pdfService->saveToOutput (at least on Windows). Somehow is it removed in the download although the temporary file has the ending (which is added automatically by getFullTempFileName() in PdfSettings.php

ervaude added a commit that referenced this issue Aug 22, 2020
Fix usage instructions. Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant