-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO-6082: nested member create request errors #1276
Conversation
...in refset member create requests ModuleId field can get its value from parent component requests. Rename incorrect `referenceSetId` field to the execpted `refsetId` field. Remove UUID pre-generation to ensure that we only generate the UUID when actually creating the refset member.
...`referenceSetId` to `refsetId`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with three small notes.
...rc/com/b2international/snowowl/snomed/datastore/request/SnomedRefSetMemberCreateRequest.java
Show resolved
Hide resolved
...rc/com/b2international/snowowl/snomed/datastore/request/SnomedRefSetMemberCreateRequest.java
Outdated
Show resolved
Hide resolved
...b2international/snowowl/snomed/datastore/request/SnomedRefSetMemberCreateRequestBuilder.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1276 +/- ##
=========================================
Coverage 48.21% 48.22%
- Complexity 13923 13930 +7
=========================================
Files 1946 1946
Lines 95122 95126 +4
Branches 10985 10985
=========================================
+ Hits 45860 45870 +10
+ Misses 46269 46268 -1
+ Partials 2993 2988 -5 ☔ View full report in Codecov by Sentry. |
....tests/src/com/b2international/snowowl/snomed/core/rest/components/SnomedConceptApiTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏
...builder as well Add comments to request fields to explain why there is no validation present for them at field level.
Performing a concept create request with the following body throws
moduleId
is missing HTTP 400 Bad Request error, how ever concept moduleId should get propagated down to the nested create request.Additionally:
refsetId
field is missing