Removed old hash syntax

Rakefile

@@ -3,5 +3,5 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new
 
-task :default => :spec
-task :test => :spec
+task default: :spec
+task test: :spec

bin/git-review

@@ -46,7 +46,7 @@ end
 
 desc 'Checkout a request\'s changes to local repo'
 command :checkout do |c|
-  c.switch [:b, :branch], :default_value => true
+  c.switch [:b, :branch], default_value: true
   c.action do |global, opts, args|
     help_now!('Request number is required.') if args.empty?
     ::GitReview::Commands.checkout(args.shift, opts[:branch])

lib/git-review.rb

@@ -1,6 +1,5 @@
 ### Dependencies
 
-
 ## External Dependencies
 
 # Provide access to GitHub's API.
@@ -12,7 +11,6 @@
 # Use temporary files to allow editing a request's title and body.
 require 'tempfile'
 
-
 ## Internal dependencies
 
 # Include helper functions to make GitReview work as expected.

lib/git-review/github.rb

@@ -9,7 +9,6 @@
 # Used to retrieve hostname
 require 'socket'
 
-
 module GitReview
 
   class Github
@@ -35,9 +34,9 @@ def configure_access
       settings = ::GitReview::Settings.instance
       if settings.oauth_token && settings.username
         @github = Octokit::Client.new(
-          :login          => settings.username,
-          :access_token    => settings.oauth_token,
-          :auto_traversal => true
+          login: settings.username,
+          access_token: settings.oauth_token,
+          auto_traversal: true
         )
         @github.login
       else
@@ -256,8 +255,8 @@ def authorize
       req.basic_auth(@username, @password)
       req.body = Yajl::Encoder.encode(
         {
-          :scopes => %w(repo),
-          :note   => @description
+          scopes: %w(repo),
+          note: @description
         }
       )
       response = http.request(req)

lib/mixins/colorizable.rb

@@ -5,7 +5,6 @@ def colorize(color_code)
     "\e[#{color_code}m#{self}\e[0m"
   end
 
-
   # A couple of presets to keep the code clean.
 
   def red

lib/mixins/nestable.rb

@@ -3,14 +3,14 @@ module Nestable
   def nests(mapping)
     # Setup an accessor for all nested instances.
     attr_accessor *mapping.keys
+
     # Create a nested instance automatically on initialize.
     define_method(:initialize) do |arguments = nil|
       mapping.each do |attribute, klass|
         self.instance_variable_set "@#{attribute}".to_sym, klass.new
       end
       super arguments if arguments
     end
-
   end
 
 end

lib/models/commit.rb

@@ -3,8 +3,8 @@ class Commit
   include Accessible
   extend Nestable
 
-  nests :user => User,
-        :repository => Repository
+  nests user: User,
+        repository: Repository
 
   attr_accessor :sha,
                 :ref,

lib/models/request.rb

@@ -3,7 +3,7 @@ class Request
   include Accessible
   extend Nestable
 
-  nests :head => Commit
+  nests head: Commit
 
   attr_accessor :number,
                 :title,

spec/git-review/commands_spec.rb

@@ -198,7 +198,7 @@
       comment = 'Reviewed and approved.'
       github.should_receive(:add_comment).
         with('some_source', request_number, 'Reviewed and approved.').
-        and_return(:body => comment)
+        and_return(body: comment)
       subject.should_receive(:puts).with(/Successfully approved request./)
       subject.approve(1)
     end
@@ -207,7 +207,7 @@
       message = 'fail'
       github.should_receive(:add_comment).
         with('some_source', request_number, 'Reviewed and approved.').
-        and_return(:body => nil, :message => message)
+        and_return(body: nil, message: message)
       subject.should_receive(:puts).with(message)
       subject.approve(1)
     end
@@ -377,7 +377,7 @@
     context 'when sending pull request to upstream repo' do
 
       let(:upstream) {
-        Hashie::Mash.new(:parent => {:full_name => 'upstream'})
+        Hashie::Mash.new(parent: {full_name: 'upstream'})
       }
 
       before(:each) do

spec/git-review/github_spec.rb

@@ -44,8 +44,7 @@
       it 'from insteadof url' do
         url = 'git@github.com:foo/bar.git'
         config = {
-            'url.git@github.com:a/b.git.insteadof' =>
-                'git@github.com:foo/bar.git'
+          'url.git@github.com:a/b.git.insteadof' => 'git@github.com:foo/bar.git'
         }
         subject.send(:insteadof_matching, config, url).
             should == %w(git@github.com:foo/bar.git git@github.com:a/b.git)

spec/git-review/local_spec.rb

@@ -39,6 +39,7 @@
 
   end
 
+
   describe '#load_config' do
 
     it 'reads config into hash' do
@@ -131,8 +132,8 @@
 
     it 'does not delete the branch if request is not closed' do
       open_request_number = 123
-      request = Hashie::Mash.new({:state => 'open',
-                                  :number => open_request_number})
+      request = Hashie::Mash.new({state: 'open',
+                                  number: open_request_number})
       gh.stub(:pull_request).and_return(request)
       subject.should_not_receive(:delete_branch)
       subject.clean_single(open_request_number)
@@ -141,8 +142,8 @@
     it 'deletes branch if request is found and no unmerged commits' do
       subject.stub(:unmerged_commits?).and_return(false)
       request_number = 1
-      request = Hashie::Mash.new({:head => {:ref => 'some_branch'},
-                                  :state => 'closed'})
+      request = Hashie::Mash.new({head: {ref: 'some_branch'},
+                                  state: 'closed'})
       gh.stub(:pull_request).and_return(request)
       subject.should_receive(:delete_branch).with('some_branch')
       subject.clean_single(request_number)
@@ -151,7 +152,7 @@
     it 'does not delete branch if there is unmerged commits' do
       subject.stub(:unmerged_commits?).and_return(true)
       request_number = 1
-      request = Hashie::Mash.new({:number => request_number})
+      request = Hashie::Mash.new({number: request_number})
       gh.stub(:pull_request).and_return(request)
       subject.should_not_receive(:delete_branch)
       subject.clean_single(request_number)
@@ -160,8 +161,8 @@
     it 'ignores unmerged commits if force deletion is set' do
       subject.stub(:unmerged_commits?).and_return(true)
       request_number = 1
-      request = Hashie::Mash.new({:head => {:ref => 'some_branch'},
-                                  :state => 'closed'})
+      request = Hashie::Mash.new({head: {ref: 'some_branch'},
+                                  state: 'closed'})
       gh.stub(:pull_request).and_return(request)
       subject.should_receive(:delete_branch)
       subject.clean_single(request_number, force=true)

spec/mixins/accessible_spec.rb

@@ -20,7 +20,7 @@ class Baz
   end
 
   it 'initializes instances variables with provided defaults' do
-    subject = Foo.new(:bar => test_string,)
+    subject = Foo.new(bar: test_string,)
     subject.bar.should == test_string
   end
 
@@ -45,16 +45,16 @@ class Baz
   end
 
   it 'sets attributes from a hash' do
-    subject.update_attributes :bar => test_string, :baz => test_string
+    subject.update_attributes bar: test_string, baz: test_string
     subject.bar.should == test_string
     subject.baz.should == test_string
   end
 
   it 'recursively sets nested accessible attributes' do
     subject.baz = Baz.new
     subject.update_attributes(
-      :bar => test_string,
-      :baz => { :berk => test_string }
+      bar: test_string,
+      baz: { berk: test_string }
     )
     subject.baz.class.should == Baz
     subject.baz.berk.should == test_string

spec/mixins/nestable_spec.rb

@@ -7,7 +7,7 @@ class Foo
 
   class Baz
     extend Nestable
-    nests :foo => Foo
+    nests foo: Foo
   end
 
   subject { Baz.new }

spec/support/request_context.rb

@@ -17,21 +17,21 @@
 
   let(:request) {
     Hashie::Mash.new(
-        :html_url => html_url,
-        :number => request_number,
-        :state => 'open',
-        :title => title,
-        :body => body,
-        :updated_at => Time.now.to_s,
-        :head => {
-          :sha => head_sha,
-          :ref => head_ref,
-          :label => head_label,
-          :repo => head_repo,
-          :user => { :login => 'user' }
+        html_url: html_url,
+        number: request_number,
+        state: 'open',
+        title: title,
+        body: body,
+        updated_at: Time.now.to_s,
+        head: {
+          sha: head_sha,
+          ref: head_ref,
+          label: head_label,
+          repo: head_repo,
+          user: { login: 'user' }
         },
-        :comments => 0,
-        :review_comments => 0
+        comments: 0,
+        review_comments: 0
     )
   }