Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IfcRelInterferesElement DocEntity & Documentation #40

Conversation

MatthieuPERIN
Copy link
Collaborator

@MatthieuPERIN MatthieuPERIN commented May 20, 2021

  • Update Interferences Type Doc
  • Update ImpliedOrder Doc
  • Update general doc

Linked to issue #39 and #111

* Update Interferences Type Doc
* Update ImpliedOrder Doc
* Update general doc
@AlexBrad1eyCT AlexBrad1eyCT added the documentation Issues or pull requests relating to documentation label May 21, 2021
@MatthieuPERIN MatthieuPERIN marked this pull request as ready for review May 25, 2021 07:01
@AlexBrad1eyCT AlexBrad1eyCT linked an issue May 25, 2021 that may be closed by this pull request
Copy link
Collaborator

@AlexBrad1eyCT AlexBrad1eyCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few language suggestions/corrections. see comments.

Only other point is around handling the spatial-spatial physical-physical question are we adding an informal propersition or defining a restrictive where rule?

@pjanck pjanck added the IFC4x3_RC4 To be resolved before IFC4x3_RC4 label Jun 11, 2021
@AlexBrad1eyCT AlexBrad1eyCT added the EXPRESS Issues or pull requests relating to EXPRESS schema label Jun 16, 2021
@AlexBrad1eyCT AlexBrad1eyCT added this to Review in progress in IFC4x3 Jun 21, 2021
@AlexBrad1eyCT AlexBrad1eyCT removed the EXPRESS Issues or pull requests relating to EXPRESS schema label Jun 30, 2021
IFC4x3 automation moved this from Review in progress to Reviewer approved Jun 30, 2021
@AlexBrad1eyCT AlexBrad1eyCT added the EXPRESS Issues or pull requests relating to EXPRESS schema label Jul 1, 2021
@MatthieuPERIN
Copy link
Collaborator Author

Solution to be implemented (followed in #111)
 

@AlexBrad1eyCT AlexBrad1eyCT linked an issue Jul 1, 2021 that may be closed by this pull request
Copy link
Collaborator

@AlexBrad1eyCT AlexBrad1eyCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks as per discussions, will create a back log issue to possibly add some tidy diagrams some where

…Elements_update

# Conflicts:
#	IFC4x3/Sections/Core data schemas/Schemas/IfcProductExtension/Entities/IfcRelInterferesElements/Documentation.md
@AlexBrad1eyCT
Copy link
Collaborator

Merging, as meets resolution for SCTE review, open issues address open discussion points.

@AlexBrad1eyCT AlexBrad1eyCT merged commit a2ebf86 into bSI-InfraRoom:develop Jul 2, 2021
IFC4x3 automation moved this from Reviewer approved to Done Jul 2, 2021
Copy link
Collaborator

@SergejMuhic SergejMuhic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions to resolve and a few proposals.

@@ -1,12 +1,24 @@
The _IfcRelInterferesElements_ objectified relationship indicates that two elements interfere. Interference is a spatial overlap between the two elements. It is a 1 to 1 relationship. The concept of two elements interfering physically or logically is described independently from the elements. The interference may be related to the shape representation of the entities by providing an interference geometry.
The _IfcRelInterferesElements_ objectified relationship indicates that two elements interfere. Interference is a spatial and/or shape interaction between the two elements. It is a 1 to 1 relationship. The concept of two elements interfering physically or logically is described independently from the elements. The interference may be related to the shape representation of the entities by providing an interference geometry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a spatial interaction and how is it different from a shape interaction?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change have being lost/reverted in actual version of the develop branch.


* When the interference geometry is available it can be passed by the optional attribute _InterferenceGeometry_ pointing to _IfcConnectionGeometry_. The connection geometry is provided as a point, curve, surface, or solid within the placement coordinate systems of the connecting elements. The _IfcConnectionVolumeGeometry_ is the default type to be used for interference in 3D space, as indicated in e.g. clash detections.
* When the interference geometry is available it can be passed by the optional attribute _InterferenceGeometry_ pointing to _IfcConnectionGeometry_. The connection geometry is provided as a point, curve, surface, or volume within the local placement coordinate systems of the connecting elements. The _IfcConnectionVolumeGeometry_ is the default type to be used for interference in 3D space, as indicated in e.g. clash detections.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volume is not a term in geometry items. Volume is a measurement type. Solid is the proper terminology.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I cannot add a suggestion here but this "coordinate systems of the connecting elements" is ambiguous. Which element? Only one local placement can serve as the basis. I guess Implied order should influence this also?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* When the interference geometry is available it can be passed by the optional attribute _InterferenceGeometry_ pointing to _IfcConnectionGeometry_. The connection geometry is provided as a point, curve, surface, or volume within the local placement coordinate systems of the connecting elements. The _IfcConnectionVolumeGeometry_ is the default type to be used for interference in 3D space, as indicated in e.g. clash detections.
* When the interference geometry is available it can be passed by the optional attribute _InterferenceGeometry_ pointing to _IfcConnectionGeometry_. The connection geometry is provided as a point, curve, surface, or solid within the placement coordinate systems of the connecting elements. The _IfcConnectionVolumeGeometry_ is the default type to be used for interference in 3D space, as indicated in e.g. clash detections.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergejMuhic amusingly your are wrong and right at the same time! :D

  1. you are correct in the sense the term is solid, but amusingly the subtype is called IfcConnectionVolumeGeometry so theres that !
  2. it sounds ambiguous but is correct IfcConnectionGeometry subtypes are made up of 2 geometries one for the overlapping zone on RelatingElement (in its placement) and the same for RelatedElement (in its placement). so...! :p

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid was kept is the actual version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergejMuhic amusingly your are wrong and right at the same time! :D

1. you are correct in the sense the term is solid, but amusingly the subtype is called _IfcConnectionVolumeGeometry_ so theres that !

2. it sounds ambiguous but is correct IfcConnectionGeometry subtypes are made up of 2 geometries one for the overlapping zone on _RelatingElement_ (in its placement) and the same for _RelatedElement_ (in its placement). so...! :p

You have to read my comments carefully. And I would appreciate that you refrain from labeling them wrong. Thank you.

Volume is not a term in geometry items.

That is a fact. IfcConnectionGeometry is by no means a geometric item. It has been introduced specifically to not be a geometric item (or a representation item) but to "describe the geometric and topological constraints that facilitate the physical connection of two objects". Semantics.

* _ImpliedOrder_=FALSE The _RelatingElement_ and _RelatedElement_ have no priority among each other. If the interference is to be resolved then no information about whether the _InterferenceGeometry_ should be subtracted from the _RelatingElement_ or the _RelatedElement_ can be traced. This would be the case for clash detection results.
* _ImpliedOrder_=UNKNOWN No information about the priorities is provided.


The _IfcConnectionGeometry_ property is used to define the interference shape, it can be part of the shape of one of the elements of the relationship (in the case of clash, overlapping and crossing interference types) or define the interface between the two shapes (in the case of along, over and under interference types).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The _IfcConnectionGeometry_ property is used to define the interference shape, it can be part of the shape of one of the elements of the relationship (in the case of clash, overlapping and crossing interference types) or define the interface between the two shapes (in the case of along, over and under interference types).
The _InterferenceGeometry_ attribute is used to define the interference shape, it can be part of the shape of one of the elements of the relationship (in the case of clash, overlapping and crossing interference types) or define the interface between the two shapes (in the case of along, over and under interference types).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was lost/reverted in actual devellop version ...should it be back ?

* Crosses: the _RelatingElement_ is crossing the _RelatedElement_ (e.g. Railway crossing a road)
* PassesThrough: the _RelatingElement_ is passing through the _RelatedElement_ (e.g. a Road passing inside a tunnel)
* PassesOver: the _RelatingElement_ is passing over the _RelatedElement_ (e.g a bridge passing over a water canal)
* PassesUnder: the _RelatingElement_ is passing under the _RelatedElement_ (e.g a Pipe passing under a road)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we allow a mix of spatial and physical concepts? I do not like this at all. @TLiebich what do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an excellent question, to be solved by IFC TUNNEL project 😄

* PassesThrough: the _RelatingElement_ is passing through the _RelatedElement_ (e.g. a Road passing inside a tunnel)
* PassesOver: the _RelatingElement_ is passing over the _RelatedElement_ (e.g a bridge passing over a water canal)
* PassesUnder: the _RelatingElement_ is passing under the _RelatedElement_ (e.g a Pipe passing under a road)
* **Non oriented interferences types** do not imply specific values of _ImpliedOrder_ (but can still be set to precise shape interference calculation)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Non oriented interferences types** do not imply specific values of _ImpliedOrder_ (but can still be set to precise shape interference calculation)
* **Non oriented interferences types** do not imply specific values of _ImpliedOrder_ (but can still be set to for a precise shape interference calculation)

* PassesOver: the _RelatingElement_ is passing over the _RelatedElement_ (e.g a bridge passing over a water canal)
* PassesUnder: the _RelatingElement_ is passing under the _RelatedElement_ (e.g a Pipe passing under a road)
* **Non oriented interferences types** do not imply specific values of _ImpliedOrder_ (but can still be set to precise shape interference calculation)
* Clash: The _RelatingElement_ and _RelatedElement_ have a spatial or shape-based clash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spatial clash has to be defined somewhere. I am having problems understanding the difference that is implied.

IFC4x3 automation moved this from Done to Review in progress Jul 2, 2021
@SergejMuhic SergejMuhic moved this from Review in progress to In progress in IFC4x3 Jul 2, 2021
MatthieuPERIN pushed a commit to MatthieuPERIN/IFC-Specification that referenced this pull request Jul 6, 2021
…esElements_update

Update IfcRelInterferesElement DocEntity & Documentation
MatthieuPERIN pushed a commit to MatthieuPERIN/IFC-Specification that referenced this pull request Jul 6, 2021
@AlexBrad1eyCT AlexBrad1eyCT moved this from In progress to Done in IFC4x3 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or pull requests relating to documentation EXPRESS Issues or pull requests relating to EXPRESS schema IFC4x3_RC4 To be resolved before IFC4x3_RC4
Projects
Development

Successfully merging this pull request may close these issues.

IfcRelInterferesElements new usage in IFC Infra project
4 participants