Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a code formatter following Buenos Aires Smalltalk conventions #125

Merged
merged 4 commits into from
May 29, 2024

Conversation

gcotelli
Copy link
Member

  • By default is configured to follow our conventions
  • Fixed the formatting of dynamic arrays to resemble the behavior of literal arrays:
    The following code
     self doSometing: {
      self message.
      variable
    }
    is now formatted as:
     self doSometing: { self message . variable }
    only producing multiple lines if the expression is too large
  • Fixed the formatting of block bodies to indent it against the block closure bracket.
    The following code:
    [
    self message.
    variable
    ] on: Error do: []
    is now formatted as:
    [
      self message.
      variable
    ] on: Error do: []

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3a171c8) to head (7129a7e).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-candidate      #125   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
===================================================
  Files                     81        81           
  Lines                   7383      7383           
===================================================
  Hits                    7383      7383           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli marked this pull request as ready for review May 29, 2024 20:38
@gcotelli gcotelli merged commit 4fea7c4 into release-candidate May 29, 2024
64 checks passed
@gcotelli gcotelli deleted the ba-st-formatter branch May 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants