Use socket.destroy() not socket.end() on successful connection #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When socket.end() is called, a FIN packet is sent however if the other host does not respond the socket will timeout and so this module will report 'closed'. The port is open but the other host is misbehaving. This fix just forces the connection to be destroyed immediately and so means that a successful connection will always result in an 'open' status being reported.
|
Makes sense to me. |
EndangeredMassa
added a commit
that referenced
this pull request
Apr 10, 2014
Use socket.destroy() not socket.end() on successful connection
|
published in 0.2.3 |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When socket.end() is called, a FIN packet is sent however if the other host does not respond the socket will timeout and so this module will report 'closed'. The port is open but the other host is misbehaving.
This fix just forces the connection to be destroyed immediately and so means that a successful connection will always result in an 'open' status being reported.