feature/smsdb

[ThinkDigitalSoftware]

No description provided.

[ThinkDigitalSoftware]

Includes the fix I mentioned earlier plus some additional code to get the feature working.

[babariviere]

Thanks for the pull request, can you please remove assert, log and required?

[ThinkDigitalSoftware]

Sure

[ThinkDigitalSoftware]

The problem is that if it goes through without those values, it fails. So what do you suggest?

[babariviere]

Oh okay so you should let asserts but only remove required

[babariviere]

And maybe can you add a description for each assert? So the developer using this would find it more useful for debug.

Example: assert(message.body, "could not insert SMS because there is no body inside it")

[ThinkDigitalSoftware]

Right, ok. Explicit is better than implicit.

[babariviere]

Thanks you for this pull request 😁

[ThinkDigitalSoftware]

Man, thank you for the library! I'll be submitting improvements for a while, hope you don't mind 😄

[babariviere]

It's okay to me haha 😀

[ThinkDigitalSoftware]

Any way we can chat? Gitter? discord? Facebook? WhatsApp? or do you prefer here? I Can also open up an issue

[ThinkDigitalSoftware]

Also, does your example app have write capabilities yet so I can add some tests?

[ThinkDigitalSoftware]

@babariviere what do you think about a new named constructor for SmsMessage?
Maybe something like SmsMessage.valid() or something (Name needs to change) to make on that's good for writing to the SmsDb? Cause I'd rather not see assertion failures and there's not an easy way to avoid errors before running. Just a small convenience.

[babariviere]

I have Facebook and discord if you want

[babariviere]

I don't think so but you can do it if you want

[babariviere]

We can also throw an error from insert function

[ThinkDigitalSoftware]

You can find me at thinkdigital#6685 on Discord. I don't think the error is a good idea, because it may not show up until it's in production

[ThinkDigitalSoftware]

I'm an advocate of showing errors as soon as possible.

[babariviere]

But the error can be catched at runtime

[ThinkDigitalSoftware]

OK. You got it. Can you add that? I'm not that good with Java anymore. 😛