-
Notifications
You must be signed in to change notification settings - Fork 158
feature/smsdb #28
feature/smsdb #28
Conversation
switch long to String in insert method to allow the method to complete.
Includes the fix I mentioned earlier plus some additional code to get the feature working. |
Thanks for the pull request, can you please remove assert, log and required? |
Sure
|
The problem is that if it goes through without those values, it fails.
So what do you suggest?
|
Oh okay so you should let asserts but only remove required |
And maybe can you add a description for each assert? So the developer using this would find it more useful for debug. Example: |
Right, ok. Explicit is better than implicit. |
Thanks you for this pull request 😁 |
Man, thank you for the library! I'll be submitting improvements for a while, hope you don't mind 😄 |
It's okay to me haha 😀 |
Any way we can chat? Gitter? discord? Facebook? WhatsApp? or do you prefer here? I Can also open up an issue |
Also, does your example app have write capabilities yet so I can add some tests? |
@babariviere what do you think about a new named constructor for |
I have Facebook and discord if you want |
I don't think so but you can do it if you want |
We can also throw an error from insert function |
You can find me at thinkdigital#6685 on Discord. I don't think the error is a good idea, because it may not show up until it's in production |
I'm an advocate of showing errors as soon as possible. |
But the error can be catched at runtime |
OK. You got it. Can you add that? I'm not that good with Java anymore. 😛 |
No description provided.