Add jdk 19 loom virtual threads support to master #1499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `Pods` section we were pointing to a place with a slightly outdated list of projects. This patch adds the correct link to the pod registry.
# Conflicts: # .circleci/script/gen_ci.clj # .cirrus.yml # appveyor.yml # doc/build.md # doc/dev.md # resources/META-INF/babashka/deps.edn # script/bump_graal_version.clj # test/babashka/crypto_test.clj
borkdude
reviewed
Feb 19, 2023
| @@ -180,8 +187,8 @@ java -jar \"$jar\" --config .build/bb.edn --deps-root . release-artifact \"$refl | |||
| (let [docker-executor-conf {:docker [{:image "circleci/clojure:openjdk-11-lein-2.9.8-bullseye"}]} | |||
| machine-executor-conf {:machine {:image "ubuntu-2004:202111-01"}} | |||
| mac-executor-conf {:macos {:xcode "14.0.0"}} | |||
| linux-graalvm-home "/home/circleci/graalvm-ce-java19-22.3.0" | |||
| mac-graalvm-home "/Users/distiller/graalvm-ce-java19-22.3.0/Contents/Home"] | |||
| linux-graalvm-home "/home/circleci/graalvm-ce-java11-22.3.0" | |||
There was a problem hiding this comment.
You shouldn't change this, as the jdk19-loom branch needs java19
borkdude
reviewed
Feb 19, 2023
| ## Unreleased | ||
| - Add jdk19 loom virtual threads support to master |
There was a problem hiding this comment.
The goal is not to merge this to master yet, but to the jdk19-loom branch
|
@mikeananev Already made the jdk19-loom branch up to date - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.
I have read the developer documentation.
[ x] This PR corresponds to an issue with a clear problem statement.
[x ] This PR contains a test to prevent against future regressions
[ x] I have updated the CHANGELOG.md file with a description of the addressed issue.