Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make :version consistent over search and dep add commands #170

Closed
dmg46664 opened this issue Mar 4, 2023 · 1 comment
Closed

Make :version consistent over search and dep add commands #170

dmg46664 opened this issue Mar 4, 2023 · 1 comment

Comments

@dmg46664
Copy link
Contributor

dmg46664 commented Mar 4, 2023

The following outputs numbers

neil dep search libpython-clj                                                                             
:lib techascent/tech.jna :version 4.06 :description "Bindings to JNA.  Used with libpython-clj among others."
:lib clj-python/libpython-clj :version 2.024 :description nil
:lib cnuernber/libpython-clj :version 1.36 :description "libpython bindings to the techascent ecosystem"
:lib libpython-clj/libpython-clj :version 1.6-SNAPSHOT :description "libpython bindings to the techascent ecosystem"

However using the command expects strings or it will insert an EDN number which won't work ❗

neil dep add :lib clj-python/libpython-clj :version 2.024

So make the latter accept numbers and/or the former output strings.

https://clojurians.slack.com/archives/C03KCV7TM6F/p1677929356870239

@borkdude
Copy link
Contributor

borkdude commented Mar 5, 2023

An attempt in the commit above, but it's failing one test. I'd have to check later this week what's wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants